Skip to content

build(deps-dev): bump @electron/get to ^5.0.0 - #146

Open
claude[bot] wants to merge 2 commits into
mainfrom
electron-get-5
Open

claude[bot] wants to merge 2 commits into
mainfrom
electron-get-5

Conversation

@claude

@claude claude Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Requested by David Babenko-Sanders · Slack thread

Bumps the @electron/get devDependency from ^4.0.2 to ^5.0.0 (resolves to 5.1.0). 5.0 replaced got with native fetch, but this repo only calls downloadArtifact in test/globalSetup.ts and test/helpers.ts with version/platform/arch/artifactName, which that change doesn't touch, so no code changes are needed. The lockfile diff only drops got, global-agent and their transitive dependencies and adds the optional undici. Lint, build, tsc --noEmit and a typecheck of the test call sites against the 5.x types all pass locally. The vitest suite couldn't run in the sandbox because Electron release downloads from GitHub are blocked there, so CI is the real check for that.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MgVyDLfwhAvw9RN1xGg4EY
@socket-security

socket-security Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​electron/​get@​4.0.2 ⏵ 5.1.099 +1100100 +182 +1100

View full report

@dsanders11
dsanders11 marked this pull request as ready for review October 20, 2026 01:00
@dsanders11
dsanders11 requested a review from a team as a code owner October 20, 2026 01:00

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward devDependency version bump. Checked package.json/yarn.lock diff and confirmed the only call sites of @ electron/get (test/helpers.ts, test/globalSetup.ts) use downloadArtifact with simple options unaffected by the got-to-fetch internal change; lockfile changes are just the expected transitive dependency cleanup (got, global-agent removed; undici added as optional).

Extended reasoning...

The change touches only package.json and yarn.lock, bumping the @ electron/get devDependency from ^4.0.2 to ^5.0.0 and regenerating the lockfile accordingly; no application source files changed. No security-sensitive surface (auth, crypto, permissions) is touched. Verified the only usages of the bumped package are simple downloadArtifact calls in test helpers that don't rely on the removed got/global-agent internals, and no CHANGES_REQUESTED or unresolved objections appear in the timeline (one approval, socket-security comment with no indicated objection).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MgVyDLfwhAvw9RN1xGg4EY

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants