Repository navigation
build(deps-dev): bump @electron/get to ^5.0.0 - #146
claude[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MgVyDLfwhAvw9RN1xGg4EY
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Looks good, straightforward devDependency version bump. Checked package.json/yarn.lock diff and confirmed the only call sites of @ electron/get (test/helpers.ts, test/globalSetup.ts) use downloadArtifact with simple options unaffected by the got-to-fetch internal change; lockfile changes are just the expected transitive dependency cleanup (got, global-agent removed; undici added as optional).
Extended reasoning...
The change touches only package.json and yarn.lock, bumping the @ electron/get devDependency from ^4.0.2 to ^5.0.0 and regenerating the lockfile accordingly; no application source files changed. No security-sensitive surface (auth, crypto, permissions) is touched. Verified the only usages of the bumped package are simple downloadArtifact calls in test helpers that don't rely on the removed got/global-agent internals, and no CHANGES_REQUESTED or unresolved objections appear in the timeline (one approval, socket-security comment with no indicated objection).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MgVyDLfwhAvw9RN1xGg4EY
Requested by David Babenko-Sanders · Slack thread
Bumps the @electron/get devDependency from ^4.0.2 to ^5.0.0 (resolves to 5.1.0). 5.0 replaced got with native fetch, but this repo only calls downloadArtifact in test/globalSetup.ts and test/helpers.ts with version/platform/arch/artifactName, which that change doesn't touch, so no code changes are needed. The lockfile diff only drops got, global-agent and their transitive dependencies and adds the optional undici. Lint, build, tsc --noEmit and a typecheck of the test call sites against the 5.x types all pass locally. The vitest suite couldn't run in the sandbox because Electron release downloads from GitHub are blocked there, so CI is the real check for that.
Generated by Claude Code