Skip to content

build(deps-dev): upgrade vitest to v5 - #179

Merged
MarshallOfSound merged 7 commits into
mainfrom
vitest-5
Oct 22, 2026
Merged

MarshallOfSound merged 7 commits into
mainfrom
vitest-5

Conversation

@claude

@claude claude Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

This moves the test suite to Vitest 5 (vitest and @vitest/coverage-v8 to ^5.0.1). Vitest 5 needs Node 22.12+, so the engines floor goes from 22 to 22.12.0 and the CI, check-dist and lint workflows now run on Node 24, which also matches the action's node24 runtime. Vite is now a required peer of Vitest rather than a transitive dependency, so it is added as a devDependency at ^8.3.0, reusing the 8.3.0 already in the lockfile. @types/node goes from ^20 to ^24 to line up with the runtime and with Vite's peer range; that bump needed no source changes. No tests or config used APIs Vitest 5 removed, there are no snapshots, and the rebuilt dist/ is unchanged. Install, format check, lint, typecheck, tests with coverage, and the dist comparison all pass locally.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@claude
claude Bot requested review from a team as code owners October 7, 2026 18:01
@socket-security

socket-security Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​vitest/​coverage-v8@​4.0.5 ⏵ 5.0.39910079 +1199 +2100
Updatedvitest@​4.1.11 ⏵ 5.0.39810079 +199100
Updated@​types/​node@​20.19.23 ⏵ 24.19.2100 +110081 +195100
Addedvite@​8.3.4991008298100

View full report

@dsanders11 dsanders11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claude, lets create a .nvmrc file here in the repo and point CI to it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@claude

claude Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Added .nvmrc (Node 24) and switched the CI, check-dist and lint workflows to node-version-file: .nvmrc in cb172a6.


Generated by Claude Code

@claude
claude Bot requested a review from dsanders11 October 7, 2026 18:18
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
Moves vite off 8.3.0, which is affected by GHSA-587h-7wmj-h5pm
(>=8.3.0 <8.3.3). 8.3.4 is the newest patched 8.x that passes the
repo's npmMinimalAgeGate; the range floor is raised so the vulnerable
versions can no longer be resolved.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@socket-security

socket-security Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

Main's vite 8.3.4 bump (#181) locked rolldown 1.2.15, its bindings,
@oxc-project/types 0.155.0 and postcss 8.5.31, all published less than
7 days ago. Pin rolldown back to 1.2.14 and postcss to 8.5.30
(lockfile-only) to stay outside the minimal age gate.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@MarshallOfSound
MarshallOfSound merged commit be6ecf7 into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the vitest-5 branch October 22, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants