Skip to content

ci: move Node 20 jobs to a supported Node line - #182

Merged
MarshallOfSound merged 2 commits into
mainfrom
ci/drop-node-20
Oct 22, 2026
Merged

MarshallOfSound merged 2 commits into
mainfrom
ci/drop-node-20

Conversation

@claude

@claude claude Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

The lint, CI and check-dist jobs (linter.yml, ci.yml, check-dist.yml) move off end-of-life Node 20 to Node 24.x, matching the action runtime (node24) and the esbuild target, and within engines >=22. The floating setup-node steps now set check-latest: true. The bundle does not depend on the host Node version (rebuilt dist is byte-identical under Node 20 and 22).


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MM6DBDZdmumVSaiGNt2vF7
@claude
claude Bot requested review from a team as code owners October 21, 2026 23:44
@claude

claude Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

The "Check dist/" failure was already there on main and this PR didn't cause it. Check dist has been failing on main since 9406233 (#175, undici 6.28.0 → 6.28.1), because that Dependabot bump didn't regenerate dist/. The diff in this run is that undici change (setImmediate/clearImmediate, headersSent in the retry handler). Rebuilding with yarn bundle on main under Node 20 and Node 22 gives the same byte-identical output, so the Node version doesn't affect the bundle. Regenerating dist/ for the undici bump should be its own PR.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MM6DBDZdmumVSaiGNt2vF7
@claude

claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Ported the dist/ rebuild from #183 here so Check dist/ goes green on this PR; the commit becomes a no-op once #183 merges.


Generated by Claude Code

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 00:02
@MarshallOfSound
MarshallOfSound merged commit 8cf2b6e into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the ci/drop-node-20 branch October 22, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants