Repository navigation
build: leave the server's boundary NetworkPolicy rules to infra - #452
Draft
claude[bot] wants to merge 1 commit into
Draft
claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
The server's rules that reach outside trop (the Envoy Gateway and the Datadog agents in, DNS and public 443 out) are now electron/infra's platform-server NetworkPolicy, which the cluster no longer lets this repo write: it rejects ipBlock and foreign-namespace peers here. Keep only the rules between the server and the sandbox Jobs, and the default-deny. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T66EoAUJ3zB8uLwRT79JV2
jkleinsc
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested via Slack thread
This trims
deploy/base/networkpolicies.yamlto the rules between the server and the sandbox Jobs (plus the default-deny), because electron/infra#470 moves the server's boundary rules (the Envoy Gateway and the Datadog agents in, DNS and public 443 out) into a Terraform-ownedplatform-serverNetworkPolicy and rejects ipBlock or foreign-namespace peers in this repo's policies. That policy also excludesapp.kubernetes.io/component: sandboxpods, so a Job the server labelsname: serverstill gets no egress. It must merge only after electron/infra#470 is applied; until then the platform policy is not there and the server would lose DNS, GitHub and its ingress.I've checked the rendered prod output and the remaining policies against the originals, but not against a running cluster.
Generated by Claude Code