Skip to content

FlatpakBackend: Fix xml handling with newer libxml - #2447

Merged
leolost2605 merged 2 commits into
mainfrom
leolost/fix-xml
Oct 1, 2026
Merged

leolost2605 merged 2 commits into
mainfrom
leolost/fix-xml

Conversation

@leolost2605

Copy link
Copy Markdown
Member

Newer libxml requires explicitly passing the option XML_PARSE_UNZIP if decompression is required: https://gitlab.gnome.org/GNOME/libxml2/-/commit/063add1b298450637fd7a0fbd2f515b10e71d00d

XML_PARSE_UNZIP isn't available in the vapi though so just pass the raw value. We have to switch to manually decompressing anyways sometimes in the future because libxml plans to remove built in compression support entirely.

Fixes #2445

@leolost2605
leolost2605 requested a review from a team October 1, 2026 14:26
Comment thread src/Core/FlatpakBackend.vala

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love a comment, but this works! Nice fix :)

@danirabbit danirabbit added this to OS 9 Oct 1, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Oct 1, 2026
Co-authored-by: Danielle Foré <danielle@elementary.io>
@leolost2605
leolost2605 enabled auto-merge (squash) October 1, 2026 16:27
@leolost2605
leolost2605 merged commit c6154de into main Oct 1, 2026
4 checks passed
@leolost2605
leolost2605 deleted the leolost/fix-xml branch October 1, 2026 16:29
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fails to load appstream on OS 9

2 participants