Skip to content

Show similar monitor labels in both Wayland and X11 sessions - #445

Draft
jeremypw wants to merge 6 commits into
mainfrom
jeremypw/window-labels/wayland-x11
Draft

Show similar monitor labels in both Wayland and X11 sessions#445
jeremypw wants to merge 6 commits into
mainfrom
jeremypw/window-labels/wayland-x11

Conversation

@jeremypw

@jeremypw jeremypw commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Builds on #401 but retains functionality in X11 for now.

The stable build CI fails because a method in libpantheon-wayland-1 has not been released yet so marking as blocked. Given that OS9 is now the development target and that only supports Wayland this will need adjusting anyway.

@jeremypw
jeremypw force-pushed the jeremypw/window-labels/wayland-x11 branch from 05ac364 to d6ca3df Compare May 27, 2026 19:09
@jeremypw

Copy link
Copy Markdown
Collaborator Author

Puzzling why CI fails in stable - for some reason the ExtendedBehaviour interface is not recognized or is different there.

@jeremypw
jeremypw requested a review from a team May 27, 2026 19:24
@jeremypw
jeremypw marked this pull request as ready for review May 27, 2026 19:24
@jeremypw

jeremypw commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

@danirabbit I see that the make_monitor_label method was added after the last stable release of pantheon-wayland - presumably causing the CI failure. Is there any reason why a stable release of that library cannot be made? I see you made the previous one.

@zeebok zeebok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I can try to test it if you'd like but last time I used Classic Session is was not stable for me for whatever reason :-/

@flodavid

Copy link
Copy Markdown
Contributor

“window labels” should be replaced by “monitor labels” in the PR title I think ?

@jeremypw jeremypw changed the title Show similar window labels in both Wayland and X11 sessions Show similar monitor labels in both Wayland and X11 sessions Jun 10, 2026

@leolost2605 leolost2605 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to get #401 working for everyone so that we don't get two completely different code paths. The infrastructure on the gala side should be in place for that and for me it's already working

@flodavid

Copy link
Copy Markdown
Contributor

I tested this and it does fix the issue introduced by #401 on X

@zeebok

zeebok commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This looks to have the same error on stable as the other PR?

@jeremypw

Copy link
Copy Markdown
Collaborator Author

@zeebok. Looks like the make_monitor_label () in libpantheon-wayland-1 has not been released yet so it is not being found in the stable build; hence the CI failure. So this PR will have to be marked blocked I guess. It will need adjusting for OS9 anyway.

@jeremypw
jeremypw marked this pull request as draft August 27, 2026 18:00
@jeremypw jeremypw added the Status: Blocked Something else needs to be done before this can be fixed label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Blocked Something else needs to be done before this can be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants