Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
appearance,multiline, and boundedmax_rowsoptions onGPUI.UI.input/1, preserving the default bordered single-line input. Multiline inputs wrap and grow up to their row limit; Enter submits and Shift+Enter inserts a newline.Forward Shift+Enter as a controlled change because the underlying component inserts that newline silently and emits
PressEnter, notChange. Expose multiline accessibility semantics while keeping masked values private. Multiline mode and row limits are construction options: callers must use a new ID when changing them.Evidence
Native tests exercise Shift+Enter followed by controlled reconciliation and Enter submission, wrapping at a fixed width, and growth stopping at two rows. Existing single-line edit/reconciliation tests remain green.
The broader native controls suite has three button/radio failures also reproduced on unmodified upstream
main. Clean package validation fails in the unchanged transitivegpui-componentdependency due to incompatible upstream APIs, before compiling this bridge.Release Notes: