Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept optional
GPUI.Text.StyleRunvalues on code lines and render their colors, weights, and font styles natively. Callers supply ranges in the original line's UTF-16 coordinates; native rendering translates them to UTF-8 byte ranges after expanding tabs. This uses the existing typed text contract without adding a highlighter dependency.Validate that runs are bounded, sorted, non-overlapping, and on UTF-16 character boundaries. Ordinary code rows now honor the viewer's custom background and foreground; selection retains its high-contrast foreground and existing diff/log row colors remain intact. Omitted styles preserve plain-text lines.
Evidence
Serialization and validation tests cover emoji surrogate boundaries, invalid and overlapping ranges, multiline text, and the 512-run limit. A native Rust regression checks that highlighting
defin😀\tdeflands at the correct byte range after tab expansion. Syntax highlighting and custom code surfaces were also inspected in a native light/dark prototype.Clean package validation remains blocked in the unchanged transitive
gpui-componentdependency by incompatible upstream APIs, before compiling this bridge.Release Notes: