Repository navigation
Security: CVE-2026-107183 cherry-pick and /rerank top_n fix for the develop pin - #58
Merged
lalalune merged 3 commits intoOct 13, 2026
Merged
Conversation
…(#29942) A TOOL_ID node that arrives after TOOL_CLOSE wrote through `current_tool`, which still pointed into the just-destroyed `pending_tool_call` optional (use-after-free, then a second free of the id buffer). Clear the pointer on reset. Fixes CVE-2026-107183 in the elizaOS fork. (cherry picked from commit dbe4c3ed42343f0a7ba0fd7e808ffeaca404d29f) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A negative "top_n" passed std::min unchanged, and format_response_rerank then resized the result vector to a huge size: std::bad_alloc and HTTP 500. Return HTTP 400 for a negative top_n, as for other invalid rerank requests. No ggml-org fix exists yet (the CVE lists master as affected). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
List the ggml-org and OSV advisories that affect this fork, the fix commit for each one, and the check to run before the elizaOS gitlink moves. Keep GGML_RPC off: the RPC server advisories have no upstream fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Member
Author
|
CI note before merge: every failing job also fails on the base branch |
10 of 11 tasks
lalalune
added a commit
to elizaOS/eliza
that referenced
this pull request
Oct 13, 2026
…-107183 fixed (#36126) elizaOS/llama.cpp#58 adds two security fixes on top of the current pin ea8b3f2: the ggml-org dbe4c3e cherry-pick for CVE-2026-107183 (use-after-free in the chat PEG parser) and a 400 response for a negative /rerank top_n (CVE-2026-52132). It also adds the fork's advisory tracking document. GGML_RPC stays off. Co-authored-by: Shaw <thefutureisaweirdplace@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes for the commit that elizaOS
developpins (ea8b3f2, tagcheckpoint/metal-library-capabilities-20260924). That commit is on no branch, so this PR targets the new brancheliza/develop-pin-ea8b3f2, which points at it. After merge, elizaOS/eliza moves theplugins/plugin-local-inference/native/llama.cppgitlink to the merge commit.Changes:
dbe4c3e(#29942, inb11393): clearcurrent_toolwhenpending_tool_callis reset. The fork file differs only in line numbers.llama-server --reranking: negativetop_ncausesstd::bad_allocand HTTP 500). ggml-org master is still affected. The fork now returns HTTP 400 for a negativetop_n, like other invalid rerank requests. One test is added totools/server/tests/unit/test_rerank.py.docs/eliza-security-advisories.md: the advisory check to run before the elizaOS gitlink moves, and the status of each known advisory.Not changed: the RPC advisories (GHSA-j8rj-fmpv-wcxw / CVE-2026-34159, CVE-2026-86317) have no upstream fix.
GGML_RPCstays off (CMake default; no Eliza build script turns it on).Reachability in Alpha Phone today: none of these paths. The Android app uses
libelizainferencefor embeddings, nollama-serveris staged, and RPC is not built. The fixes are needed before llama.cpp speech and chat paths replace ONNX.Testing (macOS arm64, CPU build,
-DGGML_METAL=OFF -DGGML_RPC=OFF -DLLAMA_BUILD_TESTS=ON):cmake --build build --target llama-server test-chat-peg-parser: builds with no errors.build/bin/test-chat-peg-parser: 32 tests, 198 assertions, 0 failures.git merge-base --is-ancestorcannot be used for dbe4c3e because this is a cherry-pick; the commit message has(cherry picked from commit dbe4c3ed...).tools/server/tests(needs a reranker model download) and an ASAN reproduction of the use-after-free.AI disclosure: Claude Code wrote this change for the elizaOS maintainers, from the Alpha Phone security review.
🤖 Generated with Claude Code