Repository navigation
Bring reviewed speech type-check fixes onto main - #70
Merged
Merged
Conversation
- HPARAMS in the converter holds ints, floats and lists; annotate it as dict[str, Any] so ty does not infer a union for every lookup. - The reference dumper imports kokoro, misaki and espeakng_loader, which CI does not install; give tools/paradee/tools the same ty override as tools/kokoro/tools. - Final newline in kokoro-decoder-front.h (missing before this PR too). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the reviewed fixes from #69 onto main after #65 and #66 merged. This fixes the converter's mixed-value configuration type and includes its reference script in the existing environment-specific type-check rules. The C++ change adds the missing final newline.
Validation: Python compilation and diff checks pass. No native algorithm changes.
AI disclosure: Codex assisted with this maintainer-requested merge and validation.