Repository navigation
build: repair architecture tests and package configuration - #80
Merged
Merged
Conversation
Assisted-by: Codex
Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The architecture test target fails to compile at 56e70ff because its assistant fixture calls the removed pre-norm embedding APIs. Use the current NextN setter/getter and update the comment to match the API. This repairs the test build used by the native dependency pinned in elizaOS/eliza#36270.
The follow-up also closes the outer condition in the installed ggml CMake package config with endif() and classifies Kokoro as a no-RoPE architecture. These repair the package-consumer configure failure and the compiler switch error exposed by CI.
Validation
Requirements