Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/architecture/01-overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ start. The default build includes only Linux TCP and io_uring. The opt-in
`LAVIK_KERNEL_BYPASS` build includes DPDK and SPDK together; it does not
activate them. Startup defaults remain Linux TCP and io_uring, including for
the Meta control plane. Each worker owns one io_uring shared by kernel
network/storage I/O, timers and wakeups; the DPDK adapter borrows that ring.
network/storage I/O, timers and wakeups. Its `NetBackend` and `StorageBackend`
adapters borrow that ring and independently encapsulate network and storage
backend selection; the DPDK adapter also borrows it. The worker initializes the
ring before the adapters and stops both adapters before shutting down the ring.
The optional DPDK network backend serves
plaintext IPv4 TCP through Bycorf's private FreeBSD stack while preserving the
same RESP stream interface and worker ownership. Software packet forwarding
Expand Down
3 changes: 2 additions & 1 deletion include/lavik/command_args.h
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,8 @@ class CommandArgsHandle {
Get().assign(first, last);
}
template <typename Iterator>
void insert(CommandArgsView::Iterator pos, Iterator first, Iterator last) {
void insert([[maybe_unused]] CommandArgsView::Iterator pos, Iterator first,
Iterator last) {
// Synthesis only appends; arbitrary insertion would invalidate offsets and
// borrow semantics. Rewriters build an independent command instead.
assert(pos == end());
Expand Down
2 changes: 1 addition & 1 deletion src/redis/lua_eval.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ struct LuaExecutionStep {
std::string reply_;
CommandOutcome outcome_{};
// Newly constructed errors only; forwarded child errors were already counted.
std::vector<LuaErrorCount> errors_;
std::vector<LuaErrorCount> errors_{};
bool scheduler_yield_ = false;
};

Expand Down
1 change: 1 addition & 0 deletions src/redis/server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
#if BYCORF_KERNEL_BYPASS
#include "bycorf/io/dpdk_backend.h"
#endif
#include "bycorf/io/spdk_storage.h"
#include "bycorf/net/server.h"
#include "bycorf/net/tcp_service.h"
#include "bycorf/net/tcp_stream.h"
Expand Down