Repository navigation
fix: update Bycorf for reusable DPDK socket handles - #455
Merged
Merged
Conversation
DPDK handle capacity now limits concurrently live or draining sockets instead of cumulative connection churn. Pending operations retain the old identity until completion delivery; Lavik networking call sites remain unchanged.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Long-running DPDK workers can exhaust their monotonically increasing socket handle namespace despite closing connections. Update Bycorf to recycle handles safely.
Uses the merged fix from eloqdata/bycorf#32, now on Bycorf main.
Behavior before and after
Previously, cumulative connection churn could permanently cause
EMFILEon a worker. With this update, capacity limits simultaneously live or draining sockets. Closed handles become reusable after pending I/O and completion callbacks retire.Lavik networking call sites and
WriteAll/WriteAllVAPIs remain unchanged.Implementation
Update only the
bycorfgitlink from7c377436989d9219e2aef4b45638d1d53fd4673btoad14f2508c9a98bc09de117368bc483ea387eadf.Design decisions and alternatives
Bycorf uses worker-local slot pins and a free list. Waiting until old operations retire prevents reuse from redirecting stale I/O to a new socket, without a generation counter or cross-worker locks.
Documentation and comments
The Bycorf change updates networking architecture and socket lifecycle comments. This gitlink update changes no Lavik module boundaries or call flows.
Test plan
Run from the Bycorf checkout:
18 new tests and 34 existing networking regressions pass. Separately, 31 slot/kernel runtime tests pass under ASAN/UBSAN. The merged Bycorf commit has an identical source tree to the tested PR head, verified with
git diff --exit-code 6f7ecbff95366967b86b56d245f848a8981445a6 ad14f2508c9a98bc09de117368bc483ea387eadf. Lavik itself was not rebuilt or end-to-end tested.Risk assessment
DPDK tests use a virtual ring PMD with controlled send/connect readiness; physical NIC behavior was not tested. Sanitizers cover the slot table and kernel runtime, not the DPDK backend. Slot metadata retains peak concurrent capacity, without retaining closed transports or payload buffers.
Rollback plan
Revert this gitlink update to restore the previous Bycorf revision.
Reviewer guide
Review the lifecycle and regression tests in eloqdata/bycorf#32, then verify this PR changes only the submodule pointer.
Follow-up work
Validate with a physical NIC in the deployment environment.