Repository navigation
build: pin Bycorf RDMA registration support - #467
Merged
thweetkomputer merged 2 commits intoNov 11, 2026
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Track the independently optional Bycorf RDMA facade and memory-registration capability. Depends on eloqdata/bycorf#39; keep this PR in draft until that change merges and the submodule pin is refreshed to its final upstream commit.
Behavior before and after
The Bycorf dependency gains explicit RDMA registration with worker/context-scoped PD ownership, checked slices and retained operation leases.
BYCORF_ENABLE_RDMAremains disabled by default, independently of DPDK/SPDK. Lavik does not activate an RDMA serving transport.Implementation
Advance the Bycorf gitlink from
ad14f2508to12bfd3e31and document the capability and ownership boundary in the system overview. This range includes the already-merged worker sleep coordination change (ac78acf, eloqdata/bycorf#33) and the RDMA registration change.Design decisions and alternatives
Keep device resources lazy and worker/context-scoped. Registrations retain MR/PD/context, while applications own backing memory and remote quiescence. Existing storage registration has its own contract.
Documentation and comments
Updated the system overview and linked Bycorf's focused RDMA ownership document. The implementation PR contains API comments and Bycorf architecture/build documentation.
Test plan
Bycorf was built with Clang 18, Debug and
BYCORF_ENABLE_WERROR=ONon Linux ARM64. The RDMA configuration additionally enabledBYCORF_ENABLE_RDMA.The parent commit hooks passed/skipped as applicable. The full Lavik suite has not been rerun locally for this dependency bump; integration CI remains required before merge.
Risk assessment
RDMA remains opt-in. The submodule range also advances worker sleep coordination, so Lavik runtime integration checks matter. The current pin is the upstream PR head and must be replaced with the final merged commit before this draft is ready.
Rollback plan
Revert this commit to restore the previous submodule pin and overview.
Reviewer guide
Review the RDMA implementation in eloqdata/bycorf#39, then verify the final gitlink and the overview's ownership description here.
Follow-up work
After eloqdata/bycorf#39 merges, refresh the pin and complete Lavik integration checks before marking this PR ready.