Skip to content

build: pin Bycorf RDMA registration support - #467

Merged
thweetkomputer merged 2 commits into
eloqdata:mainfrom
thweetkomputer:feat/bycorf-rdma-registration
Nov 11, 2026
Merged

thweetkomputer merged 2 commits into
eloqdata:mainfrom
thweetkomputer:feat/bycorf-rdma-registration

Conversation

@thweetkomputer

Copy link
Copy Markdown
Collaborator

Context

Track the independently optional Bycorf RDMA facade and memory-registration capability. Depends on eloqdata/bycorf#39; keep this PR in draft until that change merges and the submodule pin is refreshed to its final upstream commit.

Behavior before and after

The Bycorf dependency gains explicit RDMA registration with worker/context-scoped PD ownership, checked slices and retained operation leases. BYCORF_ENABLE_RDMA remains disabled by default, independently of DPDK/SPDK. Lavik does not activate an RDMA serving transport.

Implementation

Advance the Bycorf gitlink from ad14f2508 to 12bfd3e31 and document the capability and ownership boundary in the system overview. This range includes the already-merged worker sleep coordination change (ac78acf, eloqdata/bycorf#33) and the RDMA registration change.

Design decisions and alternatives

Keep device resources lazy and worker/context-scoped. Registrations retain MR/PD/context, while applications own backing memory and remote quiescence. Existing storage registration has its own contract.

Documentation and comments

Updated the system overview and linked Bycorf's focused RDMA ownership document. The implementation PR contains API comments and Bycorf architecture/build documentation.

Test plan

Bycorf was built with Clang 18, Debug and BYCORF_ENABLE_WERROR=ON on Linux ARM64. The RDMA configuration additionally enabled BYCORF_ENABLE_RDMA.

cmake --build /tmp/bycorf-no-rdma-stage2 -j 8
ctest --test-dir /tmp/bycorf-no-rdma-stage2 --output-on-failure
# 110/110 passed

cmake --build /tmp/bycorf-rdma-stage2 -j 8
BYCORF_RDMA_TEST_DEVICE=rxe_bycorf0 ctest --test-dir /tmp/bycorf-rdma-stage2 --output-on-failure
# 119/119 passed, including real Soft-RoCE registration and shared-ring tests

git diff --cached --check
# Passed before commit

The parent commit hooks passed/skipped as applicable. The full Lavik suite has not been rerun locally for this dependency bump; integration CI remains required before merge.

Risk assessment

RDMA remains opt-in. The submodule range also advances worker sleep coordination, so Lavik runtime integration checks matter. The current pin is the upstream PR head and must be replaced with the final merged commit before this draft is ready.

Rollback plan

Revert this commit to restore the previous submodule pin and overview.

Reviewer guide

Review the RDMA implementation in eloqdata/bycorf#39, then verify the final gitlink and the overview's ownership description here.

Follow-up work

After eloqdata/bycorf#39 merges, refresh the pin and complete Lavik integration checks before marking this PR ready.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thweetkomputer
thweetkomputer marked this pull request as ready for review November 11, 2026 06:04
@thweetkomputer
thweetkomputer merged commit ab2f287 into eloqdata:main Nov 11, 2026
7 checks passed
@thweetkomputer
thweetkomputer deleted the feat/bycorf-rdma-registration branch November 11, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant