You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pin Bycorf's optional RDMA RC connection implementation merged in eloqdata/bycorf#40. The submodule now points to upstream main commit 67a591e.
Behavior before and after
The pinned Bycorf version adds worker-owned RC Listen/Accept/Connect/Close, connection deadlines, CM private data, and notification-driven progress through the existing io_uring. Lavik's serving transport selection is unchanged; RDMA remains optional and disabled by default.
Implementation
Advance the Bycorf submodule from 150a50f to 67a591e and synchronize the architecture overview with its connection, CQ ownership, and shutdown model. This branch is based on Lavik main at 4b1eb1431.
Design decisions and alternatives
Keep the connection implementation in Bycorf and reference its focused architecture documentation from Lavik.
Documentation and comments
Updated the system overview to describe CM/CQ/device-event integration, worker-owned contexts, fixed CQ capacity, and poll retirement.
Test plan
Validation for the Bycorf ownership update (the subsequent branch-hint adjustment also passed all 24 RC fake-provider tests and the installed pre-commit hook):
Clang 18 RDMA suite: 149 tests passed and 7 device-dependent tests skipped before adding the final lazy-Accept regression.
/home/ubuntu/.cache/bycorf-localrefs/rdma/bycorf_rdma_rc_fake_tests — final RC suite 24/24 passed.
ASan/UBSan: 7 local-reference-counting tests and all 24 RC fake-provider tests passed.
Formatting, whitespace checks and commit hooks passed.
Verified git diff --exit-code 325cc3c 67a591e in Bycorf: the merged commit has an identical source tree to the tested PR head. The pin update requires no code changes.
The latest revision uses non-atomic ownership for RC state, requiring all associated handles and coroutine frames to be released on their creating thread. Server shutdown has a dedicated regression test for this behavior. Exported memory/context handles retain their existing shared ownership.
Earlier revisions passed Soft-RoCE integration tests; the current host has no Soft-RoCE device, so those checks were not rerun. A full Lavik build/test run was not performed for this pin-only integration change.
Risk assessment
The optional RDMA path adds device/event lifetime handling. Validation covers Soft-RoCE and injected failures; physical RNIC providers remain untested. Lavik does not enable an RDMA serving path in this PR.
Rollback plan
Revert this commit to restore the prior Bycorf pin and architecture description.
Reviewer guide
Review the Bycorf implementation and validation in eloqdata/bycorf#40, then check the submodule pin and overview update here.
Follow-up work
RDMA data-posting APIs are outside this change.
Summary by CodeRabbit
Documentation
Updated the architecture overview to describe optional RC connections, RDMA registration, shared-ring notifications, worker-owned device contexts, and fixed shared completion-queue capacity.
Clarified how connection state is retained until completion or ring quiescence, and how registration handles are owned.
Removed descriptions of channel readiness and lazy worker- or context-scoped protection-domain acquisition.
No actionable comments were generated in the recent review.
Walkthrough
The bycorf subproject reference advances to a newer commit. The architecture overview updates its description of optional RC connections and registration, worker-ring notifications, device-context ownership, shared-CQ capacity, close-state retention, and registration-handle ownership.
Changes
Bycorf architecture update
Layer / File(s)
Summary
Reference and architecture overview bycorf, docs/architecture/01-overview.md
The bycorf reference advances to a new commit. The overview documents optional RC connections and registration, worker-ring notifications, device-context ownership, shared-CQ capacity, close-state retention, and registration-handle ownership.
This change advances the Bycorf dependency and updates the architecture documentation. Confirm that the pinned Bycorf commit is the merged one and is reachable from the configured remote before merging; no other concrete problem was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "build: pin Bycorf RC connection support" names the main change: the bycorf submodule is advanced to a commit that adds optional RDMA RC connection support, and the overview doc is updated. …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description covers the core intent: it pins the Bycorf submodule to a newer commit, explains the RC connection behavior added by that pin, and states RDMA stays optional and disabled by default. I…
Full details: Title check
Explanation
The title "build: pin Bycorf RC connection support" names the main change: the bycorf submodule is advanced to a commit that adds optional RDMA RC connection support, and the overview doc is updated. The title is specific and matches the changeset. It does not describe the architecture doc update, which is a minor secondary change.
Full details: Description check
Explanation
The description covers the core intent: it pins the Bycorf submodule to a newer commit, explains the RC connection behavior added by that pin, and states RDMA stays optional and disabled by default. It includes a detailed test plan, risk assessment, rollback plan, and reviewer guide. Some template sections are thin or missing. The Context section cites commit 67a591e, but the PR objectives describe the pin as 5274f42, and the commit hash conflicts across sources. The Documentation and comments section is present but does not confirm the architecture docs were reviewed against the template's authoring standard. The Test plan lists results but not in the exact command format requested for every item. Overall the description is mostly complete.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the commit trail, Then reads the ring and worker tale. RC links wait, registrations stay, Shared queues hold their fixed array. Through close and completion, handles keep, The rabbit hops away to sleep.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 6149eaee-abd7-4f61-8ef3-858b8a97fc11
Commits
Reviewing files that changed from the base of the PR and between 2ed13cb and 8e38ba2.
Files selected for processing: 1
bycorf
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pin Bycorf's optional RDMA RC connection implementation merged in eloqdata/bycorf#40. The submodule now points to upstream main commit
67a591e.Behavior before and after
The pinned Bycorf version adds worker-owned RC Listen/Accept/Connect/Close, connection deadlines, CM private data, and notification-driven progress through the existing io_uring. Lavik's serving transport selection is unchanged; RDMA remains optional and disabled by default.
Implementation
Advance the Bycorf submodule from
150a50fto67a591eand synchronize the architecture overview with its connection, CQ ownership, and shutdown model. This branch is based on Lavik main at4b1eb1431.Design decisions and alternatives
Keep the connection implementation in Bycorf and reference its focused architecture documentation from Lavik.
Documentation and comments
Updated the system overview to describe CM/CQ/device-event integration, worker-owned contexts, fixed CQ capacity, and poll retirement.
Test plan
Validation for the Bycorf ownership update (the subsequent branch-hint adjustment also passed all 24 RC fake-provider tests and the installed pre-commit hook):
ctest --test-dir /home/ubuntu/.cache/bycorf-localrefs/default --output-on-failure— 118/118 passed./home/ubuntu/.cache/bycorf-localrefs/rdma/bycorf_rdma_rc_fake_tests— final RC suite 24/24 passed.git diff --exit-code 325cc3c 67a591ein Bycorf: the merged commit has an identical source tree to the tested PR head. The pin update requires no code changes.The latest revision uses non-atomic ownership for RC state, requiring all associated handles and coroutine frames to be released on their creating thread. Server shutdown has a dedicated regression test for this behavior. Exported memory/context handles retain their existing shared ownership.
Earlier revisions passed Soft-RoCE integration tests; the current host has no Soft-RoCE device, so those checks were not rerun. A full Lavik build/test run was not performed for this pin-only integration change.
Risk assessment
The optional RDMA path adds device/event lifetime handling. Validation covers Soft-RoCE and injected failures; physical RNIC providers remain untested. Lavik does not enable an RDMA serving path in this PR.
Rollback plan
Revert this commit to restore the prior Bycorf pin and architecture description.
Reviewer guide
Review the Bycorf implementation and validation in eloqdata/bycorf#40, then check the submodule pin and overview update here.
Follow-up work
RDMA data-posting APIs are outside this change.
Summary by CodeRabbit