Repository navigation
Add CcShardHeap payload reservation accounting #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,8 +83,12 @@ stage that is irrelevant or was already satisfied while executing a command: | |
| 1. Read-lock the range or bucket metadata that determines placement of every | ||
| write, so routing cannot change underneath commit. | ||
| 2. Acquire write ownership for buffered record keys at their local or remote CC | ||
| shards. Object commands retain the owner-shard write ownership established | ||
| during execution and acquire any additional forwarding ownership they need. | ||
| shards, including the destination payload reservation. Capacity refusal | ||
| completes the acquisition with out-of-memory instead of parking; a lock | ||
| granted before the refusal stays in the acquire result so abort cleanup | ||
| releases it ([03](03-concurrency-control.md)). Object commands retain the | ||
| owner-shard write ownership established during execution and acquire any | ||
| additional forwarding ownership they need. | ||
|
Comment on lines
+86
to
+91
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Map the new acquire-phase claims in the Step 2 now claims two things:
The existing commit-pipeline row cites only Add these paths to the commit-pipeline row, or add a new row: | Acquire refusal returns out-of-memory and keeps any granted lock in the acquire result for abort cleanup | `tx_service/src/tx_execution.cpp`; `tx_service/src/cc/local_cc_handler.cpp`; `tx_service/src/remote/remote_cc_request.cpp`; `tx_service/src/remote/cc_stream_receiver.cpp` |As per coding guidelines: "Every architecture document must end with a
|
||
| 3. Choose a commit timestamp above the transaction's start/lower bound and the | ||
| version, lock, and read-validation bounds returned by touched entries. | ||
| 4. Validate optimistic reads and release the data-read ownership that no | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a
Source maprow for the new payload-reservation claims.The new paragraph makes material claims about payload reservation:
No
Source maprow maps these claims to repository paths. The authoring standard requires every material claim to be mapped.Also, "taking it clears it so cleanup cannot release it twice" is a code-level invariant. The authoring standard routes code-level invariants to nearby source or API documentation. Consider moving it there.
Add a row like this to the
Source maptable:As per coding guidelines: "Every architecture document must end with a
Source maptable that maps its material claims to concrete repository-relative paths."Source: Coding guidelines