Skip to content

Fix unsubscribe handling in embed-pdf component #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keepitterron wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix unsubscribe handling in embed-pdf component #676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/core/src/vue/components/embed-pdf.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ provide<PDFContextState>(pdfKey, {
documentStates,
});

let unsubscribe: () => void | undefined;
onMounted(async () => {
// Merge deprecated logger prop into config (config.logger takes precedence)
const finalConfig: PluginRegistryConfig = {
Expand All @@ -83,7 +84,7 @@ onMounted(async () => {
const store = reg.getStore();
coreState.value = store.getState().core;

const unsubscribe = store.subscribe((action, newState, oldState) => {
unsubscribe = store.subscribe((action, newState, oldState) => {
// Only update if it's a core action and the core state changed
if (store.isCoreAction(action) && newState.core !== oldState.core) {
coreState.value = newState.core;
Expand All @@ -105,12 +106,13 @@ onMounted(async () => {
pluginsOk.value = true;
}
});
});

onBeforeUnmount(() => {
unsubscribe();
registry.value?.destroy();
});
onBeforeUnmount(() => {
unsubscribe?.();
registry.value?.destroy();
});

</script>

<template>
Expand Down