Repository navigation
fix: to_js dict key 'size' collides with Map.prototype.size - #134
Merged
JohanMabille merged 1 commit intoOct 14, 2026
Merged
Conversation
The LiteralMap get trap read map[k] before map.get(k), so a stored key named "size" returned Map.prototype.size (the entry count) instead of the stored value. Check map.has(k) first, matching getOwnPropertyDescriptor. Adds TestPyToJsDict regression tests (test_dict_size_key, int values, roundtrip). Full browser suite: 88 pytest + 4 async passed.
Alex-PLACET
marked this pull request as ready for review
August 27, 2026 07:41
JohanMabille
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LiteralMap get trap read map[k] before map.get(k), so a stored key named "size" returned Map.prototype.size (the entry count) instead of the stored value. Check map.has(k) first, matching getOwnPropertyDescriptor.