Skip to content

[6x] Switch EMSCRIPTEN to __EMSCRIPTEN__ in CppInterOp - #7818

Merged
DerThorsten merged 1 commit into
emscripten-forge:emscripten-6xfrom
mcbarton:6x-patch
Oct 21, 2026
Merged

DerThorsten merged 1 commit into
emscripten-forge:emscripten-6xfrom
mcbarton:6x-patch

Conversation

@mcbarton

Copy link
Copy Markdown
Contributor

This PR updates CppInterOp 6x build to change EMSCRIPTEN to __EMSCRIPTEN__ in the cpp files, so that CppInterOp can function correctly.

cc @anutosh491

@anutosh491

Copy link
Copy Markdown
Collaborator

I'll have a go at this soon :)

@anutosh491
anutosh491 self-requested a review October 21, 2026 14:16
@DerThorsten
DerThorsten merged commit 77eacb8 into emscripten-forge:emscripten-6x Oct 21, 2026
1 check passed
@mcbarton

Copy link
Copy Markdown
Contributor Author

@DerThorsten The cppinterop package never got uploaded here https://prefix.dev/channels/@emscripten-forge-bot/emscripten-forge-6x, alongside another few packages which got merged into the emscripten-6x branch at a similar time. Any idea what happened?

@anutosh491

anutosh491 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Yeah the build ci never ran. Thorsten probably overlooked that but I'll have a look into this by today.

@DerThorsten

Copy link
Copy Markdown
Contributor

just seeing what the problem is....recipes in the dir recipes/recipes_emscripten are those which are not yet migrated to 6x.
the migrated recipes are in recipes/recipes_wasm.

To land this package on 6x one needs to move the recipe to that folder and then make a PR on the 6x branch

@anutosh491

Copy link
Copy Markdown
Collaborator

yess, I'm self assigning myself this. I think there's a quite some improvements that can be made to cppinterop when building for 6x. I just haven't had the time to look !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants