Repository navigation
docs: document 1.3.0 autosuggest regression, run JS tests in CI - #42
Merged
Merged
Conversation
Mark 1.3.0 as known broken in the changelog, name 1.3.1 as the fix and withdraw the 1.3.0 guidance to bind @onkeydown:preventDefault. Sharpen the PreventDefaultKeyDown obsolete message and add an upgrade note to the component docs.
The node:test suites in tests/HerePlatform.Blazor.Tests.Js were never run automatically. Add a js-tests CI job and an optional js-test-directory input to the release workflow, set for the Blazor package.
The debounce timer thread can record a JS invocation while the test enumerates them, which failed Search_With_CircleFilter_Omits_At_Parameter intermittently with 'Collection was modified'. Retry the read instead. Also cover that arrow-key navigation does not reintroduce the static onkeydown:preventDefault modifier (fails against 1.2.0 and 1.3.0).
XElement.Value dropped self-closing <see cref/> and <paramref/> tags, leaving gaps such as 'The provides' in api-docs.json and rest-api-docs.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #40 for the 1.3.0 autosuggest keyboard regression, released as HerePlatform.NET.Blazor 1.4.1.
@onkeydown:preventDefaultguidance. ThePreventDefaultKeyDownobsolete message now says why the property is no longer needed and what to do instead.node:testsuites intests/HerePlatform.Blazor.Tests.Jsnow run in CI and before a Blazor release. Previously nothing ran them.Collection was modifiedfailure inSearch_With_CircleFilter_Omits_At_Parameter. Adds a regression test for arrow-key navigation; it fails against 1.2.0 and 1.3.0.<see cref/>and<paramref/>are rendered as text instead of leaving gaps inapi-docs.jsonandrest-api-docs.json.No runtime behavior changes.