Feature/nxt 18691: Added improvements for webpack - #399
Open
daniel-stoian-lgp wants to merge 4 commits into
Open
Feature/nxt 18691: Added improvements for webpack#399daniel-stoian-lgp wants to merge 4 commits into
daniel-stoian-lgp wants to merge 4 commits into
Conversation
# Conflicts: # npm-shrinkwrap.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Two webpack-path performance fixes, found by per-hook profiling of enact pack -p against limestone/samples/qa-a11y.
Profiling showed eslint-webpack-plugin's processAssets wait was the single largest atomic chunk of the whole build (~5.5 s on a cold qa-a11y build)
The cause is structural: the library only invokes its linter at compilation.hooks.finishModules, i.e. after webpack has already built the entire module graph. There is almost nothing left to overlap with, so the lint cost lands squarely in the critical path.
This replaces it with config/eslint-overlap-plugin.js, which spawns ESLint as a real child process at compiler.hooks.run / watchRun (before any module is built) and only awaits it at processAssets ,the same stage the original used, so plugin ordering relative to ILibPlugin etc. is unchanged. By the time processAssets is reached the child has usually already finished, making the await close to free.
Resolution
Additional Considerations
Links
nxt 18691
Comments