Repository navigation
Key panel: path, text and copy buttons stay inside the card - #14
Merged
Merged
Conversation
The "where?" panel asked for 26rem inside a Popover fixed at 18rem, so on an installed copy (where the path is long: ~/Library/Application Support/SLM Forge/.env) the text and copy buttons spilled past the card. Popover gets a `wide` size, CodeBlock can wrap long values in place of scrolling them sideways, and the panel opens towards the side with room on narrow windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: engagepy <42845567+engagepy@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a copy installed from PyPI, the "Tuner needs OPENAI_API_KEY · where?" panel spilled its long path, its text and its copy buttons outside the card.
Cause: the panel's content asked for 26rem, but
Popoveris fixed at 18rem (w-72), so the content overflowed the card. The installed path,~/Library/Application Support/SLM Forge/.env, is long enough to make it obvious.Fix:
Popovergets awidesize (26rem), used by this panel.CodeBlockgets awrapoption, so a long path or command wraps inside its block instead of scrolling sideways. The copy button stays in view.Verified in Chrome at 1440, 1280, 1100 and 900 px against a scratch server using the real installed-app path. The card stays on screen, all text and both copy buttons sit inside it, and nothing scrolls sideways. Other code blocks are unchanged. The web build is clean and 211 tests pass.
PyPI users get this in the next release.
🤖 Generated with Claude Code