Repository navigation
Use Keyring's own security notices - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyring now sends its security notices itself (entity/keyring#83), so the app's twelve copies and their base class go. One
SecurityNotice::toMailUsing()callback in the provider gives them the Maizzle template. The five emails a flow needs stay the app's own classes.The risk responder goes too: Keyring's own now emails the owner about a sign in after several failures or a long quiet period (entity/keyring#84).
Run against package
dcc4dc4: 108 PHP tests, PHPStan, Pint, lint, type checks, build, and the 35 browser tests on PHP's server and on Octane, all passing.