Repository navigation
Update to the latest Keyring and give sessions their user type - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the lock to Keyring
639d305(entity/keyring#88).Keyring's session records now say which table their user's ID is one of, so this adds a migration for the new
user_typecolumn and its index. The app has one user model, so existing sessions are filled in rather than emptied and nobody has to sign in again. The same migration remakes the hash a reserved address is found by, since that folds "ß" and a doubled "s" together now.Nothing else needed changing: the app takes the new 500ms timebox from the package's default.
Tested locally: 109 PHP tests, and the 35 browser tests on both PHP's own server and Octane.