Repository navigation
Fix what installing the example app turned up - #81
Merged
Merged
Conversation
…grations and rename the email code step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four things the example app ran into on the latest main:
keyring-pages(60 a minute per IP). The buttons keepkeyring.urlprop was an absolute URL while the other three pages give a path. It's a path now.EmailCode::asSecondFactor()is renamedasExtraStep(), since an emailed code no longer counts as a second factor.keyring:installagain on an app that has some of the migrations now adds the ones it's missing, rather than none.Docs updated for each, plus a note that a re-run doesn't register new notifications in an existing provider.
Tested on SQLite (parallel), PostgreSQL (serial) and the race tests.