Skip to content

Remove tautological tests, labels and an aliased hook field - #86

Merged
entity merged 1 commit into
mainfrom
refactor/remove-tautologies
Nov 11, 2026
Merged

entity merged 1 commit into
mainfrom
refactor/remove-tautologies

Conversation

@entity

@entity entity commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Clears out the few places that restated something instead of checking or saying it.

  • useChallenge (Vue and React) no longer returns alternatives, which was only props.alternatives under a second name. props is still returned, and the docs' example pages already read it from there.
  • Config defaults are now part of tests/Fixtures/public-api.json, so changing one fails PublicApiTest and needs an UPGRADE.md entry. The hand-copied defaults in FeaturesTest are gone.
  • Removed the strict types test: Pint's declare_strict_types rule already fails on a file without it in src, config, database, routes, stubs and lang (checked by removing the line from one file in each).
  • The notification test no longer asserts each type resolves to the class named after it, which mirrored the map in the code. It checks which types have a notification by default; the test that builds and renders every type is unchanged.
  • The late cache store test resolves SpentChallenges without asserting it is an instance of itself.
  • Docblocks on LoggedOut, FactorVerified and Keyring::factors() now say something the name doesn't.

StandardsDocsTest is left alone: its config values each back a sentence in docs/owasp-asvs.md.

To test: composer check, and bun run typecheck && bun test in js/.

@entity
entity merged commit 725939d into main Nov 11, 2026
0 of 5 checks passed
@entity
entity deleted the refactor/remove-tautologies branch November 11, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant