Conversation
… and refuse to send under it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alw swap nowreserves the miner's current quote and sends at once. A miner that re-quotes between the preview and the bid gets its lower rate pinned, and the deposit still goes out.--min-rate <float>: directional, what the taker receives per 1 sent (the rate the CLI prints).rate_display_from_fixed+directional_rate.Reservation rate X below --min-rate Y; not sending, exit 1.Reservation unreadable; not sending: <why>, exit 1.An aborted reservation costs only the reservation fee, already paid at the bid. It expires at
reserved_until, and the miner is free again.Branched from 183ae17 (the rev optimal-allways-miner pins) so the miner can pin this commit directly.
Tests:
tests/test_swap_now_min_rate.py(decision helper +swap nowCLI harness).