Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the Insider behavior docs aligned with the open App, Canvas, and Agent Server implementations. Dated October 19 and 23 records pin the included main revisions, resulting commits, and local validation; September real-provider Voice evidence stays explicitly historical. This continues the work merged in notebook PR #9.
Document Codex's Stop speaking / Resume audio control from App PR #3: it suppresses local playback while preserving microphone state and accepted OpenHands work. The OpenAI API path still cancels the speech response. Keep the separate stale-delivery App PR #4 clearly pending. The October 23 record also covers profile-owned local launches, preserved Insider instructions and identity, safe condensation, and upstream's typed HTTP 409 handling.
Remove decorative accent borders in favor of the existing neutral token, make Voice table headings 14px and normal case, and use readable teal links. Match the scenarios page to that styling. Remove obsolete typography detector exceptions; retain only scoped contrast false positives verified against Chrome's actual dark backgrounds. The new scenarios exception records 14.79:1 or better contrast for every flagged strong-text element. Add the repository's required source attribution comments without inventing prior authorship or an unverified model ID.
Validation: all three Insider HTML pages have unique IDs, valid attribution JSON, and all 32 local links/anchors resolve. Public-note privacy marker, JSON, and diff checks pass. Desktop/mobile Chrome checks confirm readable text, neutral borders, and no page-wide horizontal overflow. The configured design detector is clean. Linked implementation records report 136 App tests, 478 Canvas tests, 380 Python SDK tests, and 397 TypeScript client tests, with their scoped build/type/schema checks. These results do not claim all GitHub jobs have finished.
Includes notebook main f25ceab through a merge; the exact checked base is recorded in Git history. No Insider service restart or fresh provider/physical-device audio test was performed.