You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Quit in the panel does nothing while feedback is live: the confirmation never shows #131
The user clicked Quit in the panel and the app didn't quit (a build from main around #117/#120). SIGTERM killed it fine. A sample taken while it wasn't quitting shows the main thread idle and Engine.run still running, so NSApplication.terminate was never called.
The cause is the confirmation from #66 item 5. While feedback is LIVE, Quit sets confirmingQuit, and a SwiftUI .confirmationDialog attached to the MenuBarExtra window should ask. In a menu-bar (LSUIElement) app, that dialog doesn't show, or shows where the DJ can't see it. So Quit does nothing visible.
The terminate path itself is fine: applicationShouldTerminate → BridgeModel.quit releases holds and replies within 1 s, even if the engine hangs.
Fix
Confirm inline in the panel: the first Quit click (while feedback is live) turns the footer into "Quit? The controller stops sending to Syndicate." with Quit and Cancel. No separate dialog.
When no question is needed (feedback not live), quit at once.
The flow lives in Presentation and is tested: press → confirm or quit; confirm → quit; cancel → idle; the panel closing resets it.
Acceptance criteria
Quit always ends the app within about 1 s of the final click.
While feedback is live, the question shows inside the panel, never as a dialog that can be hidden.
The flow is tested in Presentation, test-first with /tdd.
Manual check: Quit with feedback live, then Quit with it not live.
Activity