Skip to content

After a profile swap to a flat mapping and back, following layers stays off #133

Closed

Description

@Skeyelab

Parent

#12

What's wrong

Found in the post-merge review of #128 (#115). In Coordinator.swapProfile, a swap to a profile without layers sets controllers[index].followsLayers = false on each layer entry. A later swap back to a profile with layers never sets it back, so layer-following stays off until relaunch. Example: import a flat mapping, then Reset to default.

Reproduced with a probe test on main:

  • layered rig → setProfiles (no layers) → setProfiles (bundled layers, with a small change so the swap happens)
  • status.controllers.map(\.followsLayers) is [false, false, false, false]
  • after Shift + deck select to layer 2, ch1 Play goes to deck 1, not deck 2

Fix

Derive following from the entry's setting (ControllerSettings.followLayers, default on) and the new profile's layers on every swap, instead of only switching it off.

Acceptance criteria

  • Swap to no layers and back: following is on again, and ch1 Play after a switch to layer 2 goes to deck 2.
  • An entry the DJ set to not follow stays not following through both swaps.
  • Test-first with /tdd at the Coordinator seam.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions