Skip to content

A profile swap while feedback is stale loses the stale LED look #134

Closed

Description

@Skeyelab

Parent

#12

What's wrong

Found in the post-merge review of #128 (#115). A profile swap while Syndicate's feedback is stale builds a new Bridge whose start() sets feedbackStale = false, so the stale look is lost. With leds.stale_idle set to "off", Play is 0 before the swap and dim (1) after it, while the status still says stale. The Coordinator doesn't mark the new Bridge stale again until feedback comes back and drops again.

carrySyndicateState carries Syndicate's state but not feedbackStale.

Reproduced with a probe test on main: go stale with stale_idle: off, swap profiles, and the Play LED on the new note is 1, not 0.

Fix

Carry feedbackStale across the swap (or have the Coordinator set it from its own feedback state when it builds a Bridge), and paint accordingly.

Acceptance criteria

  • A swap while stale keeps the stale look (stale_idle off: 0; dim: 1).
  • Test-first with /tdd at the Coordinator seam.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions