Skip to content

LEDs go to the LC6000's jog display (WD) port when layer 2-4 is in front #143

Closed

Description

@Skeyelab

On hardware (main babc465), no LEDs follow Syndicate. A MIDI Monitor spy on the Controller destination shows no outgoing traffic at all, though controls and feedback work.

Cause: in Coordinator.connect, the destination "taken" set doesn't allow for layers sharing one unit (#79). Layer 1 takes the Controller destination. Layers 2-4 then find it taken, miss the same-name match, and fall back to the first destination matching "LC6000": the WD (jog display) port, which macOS lists first. So with layer 2-4 in front, every LED goes to WD. There, note 1 on ch1 (90 01 xx) is also the message djay sends to reset the jog display (#121). The fallback also ignored the profile's exclude_hints.

Fix: layers of one unit share its destination, and the output fallback skips excluded ports. Tested in LayersTests with the real endpoint names in the real order. Smoke coverage (a virtual WD pair) is with agent1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions