Skip to content

An LED write made while the output is closed is cached as sent, so it is never resent #148

Closed

Description

@Skeyelab

Bridge.led(_:_:) sets ledCache[note] = velocity before guard let output. A write made while no output is open is remembered as sent. Later writes of the same velocity are skipped by the cache check, so that LED stays wrong until its state changes.

When it can happen: feedback arrives before the controller's output opens, for example at launch, or while a device is reconnecting. Any path that repaints without clearing the cache first leaves those LEDs stale.

Fix: update the cache only after a send succeeds, and not at all with no output. Test it at the Bridge or Coordinator seam: with no output open, feedback Playing 1; then the output opens; then Playing 1 again. Expect Play at 127 on the output.

Activity

  1. added this to the v1.0: native Mac app milestone on Nov 16, 2026
  2. added a commit that references this issue on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions