You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
An LED write made while the output is closed is cached as sent, so it is never resent #148
Bridge.led(_:_:) sets ledCache[note] = velocity before guard let output. A write made while no output is open is remembered as sent. Later writes of the same velocity are skipped by the cache check, so that LED stays wrong until its state changes.
When it can happen: feedback arrives before the controller's output opens, for example at launch, or while a device is reconnecting. Any path that repaints without clearing the cache first leaves those LEDs stale.
Fix: update the cache only after a send succeeds, and not at all with no output. Test it at the Bridge or Coordinator seam: with no output open, feedback Playing 1; then the output opens; then Playing 1 again. Expect Play at 127 on the output.
Activity
Merge pull request #153 from ericdahl-dev/led-cache-148