Skip to content

Ring colors look washed out: a vivid, hue-preserving ring mapping #151

Open

Description

@Skeyelab

Parent

#12

What's wrong

The user's feedback on real hardware: the jog ring colors look "a little washed out". The exact rgb222 mapping rounds each channel on its own (round(c / 255 · 3)), so a color's weaker channels land on level 1–2 and add white or grey. For example, Syndicate's yellow #ECCF65 lights as (3, 2, 1).

What to build

A vivid mapping for the ring that keeps the hue:

  1. Take out the white: subtract the smallest channel.
  2. Scale so the strongest channel is level 3.
  3. Drop a channel below 35 % of the strongest to 0.
  4. Quantize.

A near-neutral color (saturation under 20 %) keeps the exact mapping, so a grey isn't pushed into a hue.

  • Vivid is used for: the platter ring and the held hot-cue pad's brightest variant.
  • Pad cue colors stay exact, unless the user asks.
  • Settings › Decks: "Ring colors: Vivid / Exact", default Vivid, saved in BridgeSettings. Old settings load as Vivid.

Literals

Color Exact Vivid
red (255, 0, 0) 48 48
purple (128, 0, 255) 35 (2, 0, 3) = 35: 128/255 = 50 % ≥ 35 %, so red stays at level 2
teal-ish (0, 200, 180) 15 (0, 3, 3) = 15
pastel (255, 180, 180) 58 (3, 0, 0) = 48
#6C7277 (near grey) 21 21: saturation 9 %, so exact

Acceptance criteria

  • The literals above are tested at the Coordinator seam, through the ring.
  • A held pad's brightest variant is vivid. Unheld pad cue colors are unchanged.
  • The Settings switch round-trips, old settings load as Vivid, and switching repaints at once.
  • The LC6000 preview swatch follows the mode.
  • Checked on hardware by the user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions