Skip to content

Release pipeline: TestFlight and App Store from a tag #28

Open

Description

@Skeyelab

Parent

#12

What to build

A version tag builds, signs and uploads the app, the same way ShowRecorder ships, and the first TestFlight build proves CoreMIDI works in the real App Store sandbox.

Acceptance criteria

  • A release workflow, modeled on ShowRecorder's, runs on v* tags from main: archive, sign with the Apple Distribution and Mac Installer certificates, and upload with an App Store Connect API key.
  • The required secrets are listed in the developer docs. A human adds them, and creates the app record in App Store Connect.
  • A TestFlight build installed on a Mac with an LC6000 (or the virtual source) bridges Play end to end.

Blocked by

Activity

  1. added this to the v1.0: native Mac app milestone on Nov 16, 2026
  2. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Prep notes: porting ShowRecorder's release pipeline

    These notes come from a read-only pass over ShowRecorder's .github/workflows/release.yml, ci.yml, project.yml, docs/DEVELOPING.md ("Releasing to TestFlight") and scripts/ci_profile.py. No secret values were read. The workflow is still blocked by #14.

    What to copy

    release.yml, reduced to one macOS job:

    • The trigger on v[0-9]+.[0-9]+.[0-9]+ tags, permissions: contents: read, and the concurrency group.
    • The if: github.repository == 'ericdahl-dev/controller-bridge' guard, so forks and PRs never run it.
    • The "Check the tag" step: the commit must be on origin/main. MARKETING_VERSION comes from the tag, and BUILD_NUMBER is ${GITHUB_RUN_NUMBER}.${GITHUB_RUN_ATTEMPT}, so a re-run never uploads a duplicate.
    • The runs-on: macos-26 standard runner (never -large or -xlarge) and timeout-minutes: 60.
    • Writing the ASC .p8 to $RUNNER_TEMP with umask 077 and set +x.
    • The temporary keychain import of both the Apple Distribution and the Mac Installer .p12, plus set-key-partition-list and the installer-expiry print. Read CERT_SERIAL from the Distribution cert.
    • One ci_profile.py call with PROFILE_TYPE=MAC_APP_STORE and PROFILE_NAME="ControllerBridge CI Mac App Store".
    • xcodebuild archive with CODE_SIGN_STYLE=Manual, CODE_SIGN_IDENTITY="Apple Distribution", APP_PROFILE_NAME, OTHER_CODE_SIGN_FLAGS="--keychain $KEYCHAIN", and the version and build overrides.
    • The ExportOptions plist: app-store-connect, upload, manual signing, installerSigningCertificate = 3rd Party Mac Developer Installer, a single provisioningProfiles entry, uploadSymbols, and manageAppVersionAndBuildNumber false.
    • The if: always() cleanup of the key, keychain and profiles, and the if: failure() upload of the archive and upload logs.

    scripts/ci_profile.py, copied almost as it is. It finds or creates the profile through the ASC API, so nobody makes a profile by hand and nothing is created on each run. Drop the CREATE_BUNDLE_ID branch: it only registers iOS bundle IDs. Register the macOS App ID by hand instead (see the human steps below).

    scripts/preflight.sh, trimmed for this app. Keep the version and build format checks, ITSAppUsesNonExemptEncryption, the icon check and PrivacyInfo.xcprivacy. Add checks for LSUIElement, LSApplicationCategoryType and the sandbox entitlements. Drop the microphone, watch and widget checks.

    project.yml settings that #14 must include for the release to work:

    • PROVISIONING_PROFILE_SPECIFIER: $(APP_PROFILE_NAME) (empty locally), with CODE_SIGN_STYLE: Automatic locally and ENABLE_HARDENED_RUNTIME: true.
    • LSApplicationCategoryType. A Mac App Store upload is rejected without it (public.app-category.music fits).
    • ITSAppUsesNonExemptEncryption: false, CFBundleShortVersionString: $(MARKETING_VERSION) and CFBundleVersion: $(CURRENT_PROJECT_VERSION).
    • An AppIcon asset and PrivacyInfo.xcprivacy. The upload needs both.
    • Entitlements: app-sandbox, network.client and network.server. CoreMIDI needs no entitlement.

    What to drop

    • The iOS leg of the matrix, and the matrix itself (one platform means one job).
    • The Live Activity extension and Watch app: EXTENSION_* and WATCH_* variables, their profiles, their ci_profile.py calls, and their provisioningProfiles entries.
    • The soft HAS_MAC_INSTALLER_CERT check. The installer cert is required here, so a missing one should fail the job with a clear error. Keep the error line, without the "iOS still ships" logic.
    • The release/** branch allowance in the tag check. Main only for now; add it back if a release branch is ever needed.
    • testflight_notes.py and testflight_promote.py (What to Test, external groups, Beta App Review, [internal] tags). For v1, set What to Test by hand and use an internal group only. Port these later if external testers are needed.
    • From project.yml: everything for iOS and watchOS, UIBackgroundModes, orientations, NSMicrophoneUsageDescription, audio-input, the user-selected-file and bookmark entitlements, and the StoreKit config.
    • From ci.yml: the website, mixer-sim and coverage jobs. That file belongs to App shell: menu bar, CoreMIDI and UDP adapters, sandbox, CI build #14's CI build, not to this ticket.

    Secrets

    Secret Reuse from ShowRecorder? Notes
    ASC_KEY_ID Reuse Team-wide key. Its role must be able to create profiles (ShowRecorder uses an Admin key).
    ASC_ISSUER_ID Reuse Same team.
    ASC_KEY_P8 Reuse The .p8 contents.
    DEVELOPMENT_TEAM Reuse Same team ID.
    DIST_CERT_P12_BASE64 Reuse Apple Distribution certs are team-wide and sign Mac apps too.
    DIST_CERT_PASSWORD Reuse
    MAC_INSTALLER_CERT_P12_BASE64 Reuse The Mac Installer Distribution cert is team-wide.
    MAC_INSTALLER_CERT_PASSWORD Reuse

    No new secret values are needed. All eight come from Infisical showrecorder / prod. They still have to be added to this repo. The better option is to make them ericdahl-dev org secrets scoped to both repos, so a yearly cert renewal updates one place instead of two. Both certs expire yearly, and that expiry is now shared by two apps.

    New things that are not secrets:

    • An explicit macOS App ID dev.ericdahl.ControllerBridge in the developer portal.
    • The App Store Connect app record (macOS platform).
    • The provisioning profile ControllerBridge CI Mac App Store (type MAC_APP_STORE). ci_profile.py creates it on the first tag run, so no human makes it and it is never stored as a secret.

    Human steps, in order

    1. Bundle ID decided: dev.ericdahl.ControllerBridge. The App Store display name is still open in App Store submission #29, and it must not include "Syndicate". App shell: menu bar, CoreMIDI and UDP adapters, sandbox, CI build #14 uses this bundle ID in project.yml.
    2. ✅ Done (registered by lc6000-cos). developer.apple.com → Identifiers → +: register an explicit App ID for that bundle ID, platform macOS. No extra capabilities (App Sandbox is not an App ID capability).
    3. App Store Connect → Apps → +: create a new app with platform macOS, the name from App Store submission #29, primary language, bundle ID dev.ericdahl.ControllerBridge, and a SKU. Check the name is free.
    4. Confirm the ASC API key's role can create profiles (Admin). If it can't, make a new Admin key and update ASC_KEY_ID and ASC_KEY_P8 for both apps.
    5. Add the eight secrets as ericdahl-dev org secrets shared with ShowRecorder and this repo (decided). The user does this; copy the values from Infisical without printing them.
    6. After App shell: menu bar, CoreMIDI and UDP adapters, sandbox, CI build #14 and this ticket merge: create an internal TestFlight group for the app and add yourself.
    7. Tag and push v0.1.0 from main. The first run creates the CI profile. Processing takes about 5 to 15 minutes.
    8. Install from TestFlight on a Mac with the LC6000 (or the virtual source) and check Play bridges end to end. This is the real-sandbox CoreMIDI proof for AC 3.

    Open points for the implementer

    • If Syndicate ever runs on another host instead of loopback, macOS local network privacy may prompt. Consider adding NSLocalNetworkUsageDescription early; loopback-only traffic doesn't need it.
    • Document the secret list in this repo's developer docs, as AC 2 requires, modeled on ShowRecorder's "Releasing to TestFlight" section.
  3. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Decision: the App Store display name is ControllerBridge. No app with that name turned up in a search of the US App Store on 2026-11-15. The user is reserving it now by creating the App ID and the App Store Connect record early, with bundle id dev.ericdahl.ControllerBridge.

  4. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Update (2026-11-15): App ID dev.ericdahl.ControllerBridge is registered (Developer portal → Identifiers). Creating the App Store Connect record failed because the name "ControllerBridge" is already taken. The record isn't created yet; the user will pick a display name later (#29). The bundle id is unaffected.

  5. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Workflow and scripts: PR #56 ("Part of #28"). What's left here is human:

    • macOS App ID dev.ericdahl.ControllerBridge registered (lc6000-cos)
    • The eight release secrets available to this repo as ericdahl-dev org secrets (names in docs/DEVELOPING.md)
    • App Store Connect app record (macOS, bundle id above), once App Store submission #29 picks a name
    • An internal TestFlight group
    • First tag v0.1.0, then install from TestFlight and check Play end to end on a Mac with the controller (or the smoke script's virtual source). This is AC 3, the real-sandbox CoreMIDI proof.

    AC 1 (the workflow) and AC 2 (the secrets listed in the developer docs) are covered by #56 once it merges.

  6. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    TestFlight "What to Test" text (also in docs/TESTFLIGHT.md, PR #160). Paste into the build's What to Test in App Store Connect:

    Controller Bridge 1.0 plays Syndicate from a Denon LC6000 PRIME. Please try:

    • Setup: follow the setup guide on first launch. FEEDBACK should read LIVE.
    • Play a set: transport, hot cues, loops, jog, the pitch fader and the Needle Drop strip.
    • Four decks: Shift + deck select through layers 1-4. The ring and LEDs should follow each deck.
    • LEDs: pads in your cue colors, and the ring in each deck's color.
    • Recovery: unplug and replug the controller, sleep the Mac, and restart Syndicate. Everything should come back.
    • If the LEDs stay dark, read the panel's "Why no LEDs?" help. Does it tell you what to fix?

    Tell us about anything that didn't respond, lit the wrong color, or needed a relaunch.

  7. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Done (2026-11-16): the App Store Connect record is created: DeckBridge, macOS, bundle dev.ericdahl.ControllerBridge, SKU deckbridge-mac. Remaining human step: share the org signing secrets with this repo, then tag v1.0.0.

  8. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Pre-tag checklist for v1.0.0 (dry check, agent3)

    I checked the release path against main with no secrets: release.yml, scripts/preflight.sh and scripts/ci_profile.py.

    One blocker, which needs the user. This repository can't see any of the eight release secrets today: no repo secrets, and the only org secrets it has access to are unrelated. A tag now would stop at "Check the secrets".

    Needs a person (secrets and Apple)

    • Give controller-bridge access to the eight org secrets (GitHub › org settings › Secrets › each secret › Repository access), or add them as repo secrets: ASC_KEY_ID, ASC_ISSUER_ID, ASC_KEY_P8, DEVELOPMENT_TEAM, DIST_CERT_P12_BASE64, DIST_CERT_PASSWORD, MAC_INSTALLER_CERT_P12_BASE64, MAC_INSTALLER_CERT_PASSWORD.
    • The App Store Connect API key's role can create profiles (Admin), since ci_profile.py makes "ControllerBridge CI Mac App Store" on the first run.
    • dev.ericdahl.ControllerBridge is registered as a macOS App ID in the developer account. ci_profile.py never registers one. The ASC record exists (DeckBridge, SKU deckbridge-mac), so it should be.
    • The Apple Distribution and Mac Installer Distribution certificates are valid (shared with ShowRecorder). The workflow prints their expiry dates.

    Checked and OK

    • Names:
      • Display name DeckBridge, set as CFBundleDisplayName and CFBundleName.
      • Product, scheme, .app and archive paths are all ControllerBridge, consistent across release.yml, ci.yml, smoke.sh and preflight.sh.
      • Bundle id dev.ericdahl.ControllerBridge is the same in project.yml, release.yml (BUNDLE_ID) and the ASC record.
      • Profile name "ControllerBridge CI Mac App Store" is the same in release.yml, the export options and docs/DEVELOPING.md.
    • Version:
      • The tag vX.Y.Z gives MARKETING_VERSION X.Y.Z, so v1.0.0 gives 1.0.0. The tag must be on main (checked).
      • The build number is run_number.run_attempt, for example 1.1: 1–3 dot-separated integers, which ASC accepts. A re-run uploads a higher build.
      • project.yml's 0.1.0 / 1 are only local defaults.
    • Preflight on a local Release build with MARKETING_VERSION=1.0.0, CURRENT_PROJECT_VERSION=42.1: every check passes. That covers the version, build, export compliance, category, LSUIElement, privacy manifest (no tracking or collection; UserDefaults CA92.1), icon (Assets.car, 1024 px source), sandbox plus network client and server entitlements, and the new bundle id and display name checks.
    • Tools: actionlint is clean. scripts/test-preflight.sh and scripts/test_ci_profile.py pass.

    Fixed in #164

    • The secret check now covers all eight and names the missing ones. Before, it checked three, so a missing team id or password failed later in signing.
    • Preflight now checks the bundle id and the display name.

    Then

    1. Merge Release dry check: all secrets checked by name; preflight checks bundle id and display name #164.
    2. Share the secrets.
    3. Tag v1.0.0 on main: git tag v1.0.0 <merged sha> && git push origin v1.0.0.
    4. Watch Release › TestFlight (macOS). On failure, release-logs holds archive.log and upload.log.
  9. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    Status (2026-11-16, end of session): repo secrets set so far (names only checked): DEVELOPMENT_TEAM, DIST_CERT_P12_BASE64, DIST_CERT_PASSWORD, MAC_INSTALLER_CERT_P12_BASE64. Still missing: ASC_ISSUER_ID, ASC_KEY_ID, ASC_KEY_P8, MAC_INSTALLER_CERT_PASSWORD. Sources: the dist cert is in Doppler ericdahl-dev/prd (SHOWRECORDER_DIST_CERT_*); the AuthKey .p8 files and certificate .p12s are on ND_Backup (personal-2026-09-21/Downloads, ai-configs/2026-10-05/credentials). The user finishes these next session, then tags v1.0.0.

  10. Skeyelab commented on Nov 16, 2026

    @Skeyelab
    MemberAuthor

    v1.0.0 released to App Store Connect (2026-11-16): release run 43813459190 succeeded. It built, signed, passed preflight and uploaded DeckBridge 1.0.0. The first run failed only because MAC_INSTALLER_CERT_P12_BASE64 was empty; it was fixed and re-run. Next human steps: create an internal TestFlight group, add yourself, turn on automatic distribution, then install from the TestFlight app on the Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions