Skip to content

Make smoke a required gate after 5 green runs on main #46

Closed

Description

@Skeyelab

Parent

#12

What to build

Make the smoke check a real gate in CI. Today the Smoke (best-effort) step in the App build (Release, ad-hoc) job is continue-on-error, so a failing smoke run doesn't block a merge.

On #44 the smoke passed on the hosted macos-26 runner (virtual MIDI and loopback UDP both work there). But one green run is thin evidence. Flip the step once it has passed on 5 runs on main in a row.

Acceptance criteria

  • The step has passed on 5 consecutive runs on main. Link the runs in the PR.
  • continue-on-error: true is removed from the smoke step, and the step's comment no longer calls it best-effort.
  • The README's note on the smoke check says it is required in CI.
  • The job name stays App build (Release, ad-hoc), so the required check keeps working.

Blocked by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions