Repository navigation
Conversation
…codes; several palette slots in one message all apply Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
Member
Author
Post-merge review (agent2): TDD checklist plus the new testing notesClean. No follow-ups.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live bug: with the real Syndicate and feedback live, Diagnostics showed
OSC <- /Syndicate/ColorPalettewith no arguments. So deck colors never followed Syndicate (#123), and pad cue colors never took Syndicate's palette.Part of #12. Fixes ColorPalette following for #122 and #123 on real hardware.
Cause
The guide documents ColorPalette as "[i slot, i R, i G, i B]", and on the wire that's an OSC 1.1 array: type tags
,[iiii]. Our decoder (#13) treats an unknown tag as "can't size it, stop", so[ended the arguments before the first int.Fix
OSCReader:[and]carry no data, so the arguments inside are read in order and flattened. Cues sent as[is]pairs flatten to the same int, string list the cue parser already reads.[iiii][iiii]…, 32 ints flattened): both the pads' cue palette (Bridge.colorPalette) and the deck colors (the Coordinator) now read every group of four. Before, only the first group was read. This also works if Syndicate sends one message per slot.Tests (OSC bytes seam, then the Coordinator)
/Syndicate/ColorPalette,[iiii]1, 255, 0, 0 decode to four ints.,[is][is]3, "Drop", 0, "" flattens in order.Manual check, for the user: after a rebuild, Diagnostics › OSC Log shows ColorPalette with its numbers. The deck badges and the ring take Syndicate's deck colors, and the hot-cue pads take its cue colors.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1