Repository navigation
Vivid ring colors that keep the hue, with a Vivid / Exact switch - #156
Merged
Merged
Conversation
…ropped; near-greys stay exact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
…e, repainted at once Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
…rs: Vivid / Exact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
Skeyelab
enabled auto-merge
November 16, 2026 05:02
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user said the jog ring's colors looked "a little washed out" on the real LC6000. This adds a vivid, hue-preserving mapping for the ring and a held pad, with a Settings switch (default Vivid).
Part of #151 (it stays open for the user's hardware check).
Why it washed out
The exact rgb222 mapping rounds each channel on its own (round(c / 255 · 3)), so a color's weaker channels land on level 1–2 and add white. Syndicate's yellow #ECCF65 lit as (3, 2, 1).
Vivid mapping (
vividVelocity, MIDIValues)A near-gray (saturation under 20 %) has no hue to keep and uses the exact mapping, so deck 1's gray #6C7277 stays gray (21) instead of turning blue.
The pastel literal is why the white comes out first. Scaling plus the threshold alone gives (3, 2, 2) = 58 for it.
Where it's used
BridgeSettings.ringColors:rebasedpick.setRingColorspipe event, and the ring and pads repaint at onceDeckColors.ledPreview(_:mode:)).Tests
settingssnapshot shows the switch and the vivid swatches.For the user, on hardware: after the rebuild, compare Vivid and Exact under Settings › Decks › Ring colors.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1