Repository navigation
Test the --chat contacts fallback and receipt wait; fix empty-listing hint - #19
Conversation
…pty-listing hint Guards for two behaviors nothing tested: a raw --chat read works with a broken or missing contacts file, and send() waits for a receipt that arrives late (and gives up after the timeout). Both were checked by breaking the code and watching the tests fail. The "no contacts configured" hint named ~/.config/imsg-agent even when --contacts-file or $IMSG_AGENT_CONTACTS was in force; it now names the file the run actually reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC
|
Blocking: Checked, no problems found:
Minor:
|
.coverage was committed by accident and embeds absolute local paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC
|
Review against the privacy and scoping invariants. I found no blockers. I couldn't run the tests here because pytest isn't installed in the runner, so none of this has been executed. Invariants
Nits
Otherwise this looks good to merge. |
Summary
Tests for two untested behaviors, plus one hint fix.
Evidence
--chatfallback in_open_bookfailed 2 tests; makingconfirm_deliverycheck once without waiting failed 2 tests. Code restored after each.test_an_empty_listing_names_the_contacts_file_givenand..._env_var_filered -> green.imsgread.py: 87% -> 89% (lines + branches). 127 passed.Merge Danger
Door: two-way
Blast Radius: none
Tests plus one error message's wording.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC