Repository navigation
Refactor: choose the contacts file in one place - #22
Conversation
choose_contacts_file(flag) -> ContactsFile(path, origin, searched) is the only code that weighs --contacts-file, $IMSG_AGENT_CONTACTS and the search. ContactBook.open, --config and the --contacts empty-file hint all ask it, instead of each re-deriving flag/env precedence. Messages are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC
|
Reviewed the diff ( Invariants: no problems found in the changed lines
Gap in the "one place" claim Minor
I didn't review the typedstream decoder or the README install steps, since this PR doesn't touch them. |
Stacked on #21.
Summary
Evidence
test_one_choice_says_which_contacts_file_is_in_force_and_why, parametrized over flag, env and search (red → green).$IMSG_AGENT_CONTACTSis now read only in the chooser and the candidates list.Merge Danger
Door: two-way
Blast Radius: none. Messages and precedence are identical.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VCgWWsJbTMzsnA2WJkmsjC