Repository navigation
Fix exact dependency scopes and import-map JSON formatting - #1422
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conflicting exact dependency versions now receive package-specific scopes, so adding a package that requires
dep@1.0.0does not change or inherit another package'sdep@2.0.0mapping. Exact peer conflicts report the same warning as incompatible version ranges.Import-map formatting now JSON-escapes keys and values, including configuration, scopes, and integrity entries, and inserts commas only between emitted mappings. Regression tests cover dependency resolution, quoted data URLs, skipped null/empty entries, and CLI HTML updates.
Validation:
go test -mod=readonly -race ./internal/importmap ./cli