Repository navigation
Genesis: fix the Maximum Carnage hang (Z80 reset), keep sound running muted - #22
Conversation
Bumps components/genesis/gwenesis to esp-cpp/gwenesis#1. A save state written by another firmware build restored stale YM2612 pointers (operator routing, detune rows), so the FM output went silent and stray writes corrupted memory; the load now rebuilds them and keeps this build's audio rates. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
… muted) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
#2 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
There was a problem hiding this comment.
🔵 Needs a closer look
Changes to muted dual-core Z80 execution and legacy save-state interrupt restoration require Tab5 runtime validation of mute/unmute transitions and older-state resume, which the reported test does not cover.
No open issues 🎉
What changed in this PR
Updates the shared Genesis core to fix Maximum Carnage’s hang after START GAME and improve reset, mute, and save-state behavior, building on the save-state fixes in #21.
Changes:
- Corrects Z80 reset handling and restores power-on reset behavior for menu Reset.
- Keeps the Z80 and sound chips running while muted, suppressing only audio output.
- Preserves Z80
IAutoResetwhen loading older save states.
No file paths were supplied for review.
| File | Description |
|---|
Review effort: Balanced
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
ESP-IDF Size Report for 'Tab5 Emu'
FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available. |
Builds on #21 (based on its branch; retarget to
mainonce #21 is merged). Pins esp-cpp/gwenesis#2.What
Bumps the shared Genesis core to pick up:
IAutoResetset (older saves stored 0).The 68000 clock setting and wait-loop skip in that PR compile out here: this build doesn't define
M68K_OVERCLOCK_SHIFT/M68K_IDLE_SKIP.Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY