Repository navigation
The USB link from the shared emulink submodule - #25
Merged
Merged
Conversation
components/devlink, main/remote_control.hpp, tools/emulink and web/ were the same in esp-box-emu and tab5-emu; they are esp-cpp/emulink now, a submodule at components/emulink (the `emulink` component: DevLink and the header-only RemoteControl). tools/emulink and web are links into it, so `cd tools/emulink && python -m emulink` and the local web server work as before; the pages workflow publishes components/emulink/web. The board component comes from EMULINK_BOARD_COMPONENT (box-emu by default). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY
# Conflicts: # main/remote_control.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the touch PR (#24); retarget to main once it merges. The same change is in the other emulator's repo (esp-cpp/esp-box-emu).
components/devlink,main/remote_control.hpp,tools/emulinkandweb/were the same in esp-box-emu and tab5-emu. They now live in one place, esp-cpp/emulink, a submodule atcomponents/emulink.What changes here
emulinkcomponent replacesdevlinkin the component list. It containsDevLinkand the header-onlyRemoteControl, whichmainincludes with its owncart.hpp,gui.hppandsettings.hpp.idf_build_set_property(EMULINK_BOARD_COMPONENT ...), set beforeproject(). It defaults tobox-emu; the Tab5 setstab5-emu.tools/emulinkandwebare now links into the submodule, socd tools/emulink && python -m emulinkandpython3 -m http.server -d webwork as before.components/emulink/web. It now triggers on a change to the submodule's commit.What the shared copy merged
strtolinstead ofstd::from_chars(one file for both).Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01SFCMzomCZ5wRHJN4sxwkvY