Repository navigation
fix(tar,ls): tar -P/-T/--, ls quoting styles (-b, -N, -Q, --quoting-style) - #2559
Merged
Merged
Conversation
…tyle) tar keeps absolute names with -P/--absolute-names, reads member lists from -T/--files-from (- is stdin), and stops option parsing at --. ls renders names in GNU escape, c, literal and shell* quoting styles. Claude-Session: https://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA
chaliy
force-pushed
the
claude/tar-ls-gaps
branch
from
October 7, 2026 12:29
736c6ab to
6a1fed0
Compare
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 6a1fed0 | Commit Preview URL Branch Preview URL |
Oct 07 2026, 12:29 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
tar -P/--absolute-nameskeeps the leading/and skips the "Removing leading" notice.tar -T FILE/--files-from=FILEreads member names, one per line. Blank lines are skipped and-reads stdin.tar --ends option parsing, sotar -cf x.tar -- -varchives a file named-v.lssupports the GNU quoting styles:-b/--escape,-N,-Q, and--quoting-style=literal|escape|c|shell|shell-always|shell-escape|shell-escape-always."it's"in shell style and directory headers left unescaped under-b.locale/clocalestill report "not implemented".### endintar.test.sh, sotar_strip_componentsruns as its own case again.Why
Gap telemetry flagged
invalid option -- 'P','T'and'-'from tar, plusls -b, in replayed agent calls.Before
After
New and updated cases in
tar.test.shandls.test.shmatch real bash 5.2 with GNU coreutils/tar. The quoting styles also have a unit test,ls::quoting::tests::styles_match_gnu, covering control-char escapes, which the VFS keeps out of file names.Risk
Low. The default ls style (literal) is unchanged. The tar writers now take a small
TarNamesstruct instead of two bools.Checklist
cargo test -p bashkit --lib --tests, clippy, fmthttps://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA
Generated by Claude Code