Repository navigation
fix(parser): keep quoted and escaped glob characters literal - #2564
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | fd450e1 | Commit Preview URL Branch Preview URL |
Oct 07 2026, 02:57 PM |
chaliy
force-pushed
the
claude/escaped-dollar
branch
from
October 7, 2026 13:42
a715620 to
e5b6f8f
Compare
chaliy
force-pushed
the
claude/quoted-glob-literal-2
branch
from
October 7, 2026 13:42
cff28b1 to
c93b692
Compare
chaliy
force-pushed
the
claude/escaped-dollar
branch
from
October 7, 2026 14:11
e5b6f8f to
79f40ae
Compare
chaliy
force-pushed
the
claude/quoted-glob-literal-2
branch
from
October 7, 2026 14:55
c93b692 to
fd450e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
Stacked on #2563 (retargets to main when that merges).
What changed
Quoted or backslash-escaped glob characters are literal, as in bash:
a\*,a"*"anda'?'no longer glob.caseand[[ == ]]patterns:"$x",'a*',a\*and\[s\]match literally."*"zz*with no match prints*zz*(the internal escapes used to leak)."$x"zz*reads$x, not$xzz.'a'$xexpands and'a'*globs. Both used to be literal.a{1,2}"*"still brace-expands.Why
These are fidelity bugs from step 1 of the roadmap. A
caseor[[ ]]on a quoted variable that holds*,?or[took the wrong branch.Before
After
The new spec
escaped-glob.test.sh(6 cases) matches real bash.Risk
Medium, because it touches the lexer's word classification.
QuotedGlobWordconvention (quoted glob characters backslash-escaped) now coversread_wordand single-quoted words, with quote markers.expand_wordunescapes for non-glob uses. Assignments and script analysis unescape literal parts.\before glob characters when nothing matches.knowledge/foundations/parser.md.Checklist
cargo test -p bashkit --lib, integration tests, clippy, fmthttps://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA
Generated by Claude Code