Repository navigation
fix(expansion): match ?, multi-star and lone * in ${x#pat} and ${x%pat} - #2565
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | ad80231 | Commit Preview URL Branch Preview URL |
Oct 07 2026, 03:41 PM |
chaliy
force-pushed
the
claude/remove-prefix-empty-match
branch
2 times, most recently
from
October 7, 2026 14:50
86d92b5 to
1dcac3d
Compare
chaliy
force-pushed
the
claude/remove-prefix-empty-match
branch
from
October 7, 2026 15:40
1dcac3d to
ad80231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
${x#pat},${x##pat},${x%pat}and${x%%pat}follow the glob grammar:*matches the empty string for the short forms.?or several*go throughglob_match.*patterns keep the linear fast path.Why
${x#*}and${x%*}dropped a character.${x%?}(strip the last character),${p#*/*/}and${p##*.*.}were compared as literal text and removed nothing.Before
After
The new spec
remove-pattern-glob.test.shmatches real bash.Risk
Low. The new patterns use the existing capped
remove_pattern_glob(TM-DOS cap).Checklist
https://claude.ai/code/session_019aFikmptPc91Fj4N2iDXQA
Generated by Claude Code