Repository navigation
test(spec): import 1,044 bash-verified cases from the BashBox test suite - #2575
Merged
Merged
Conversation
Copies (script, stdout) pairs from shipfastlabs/bashbox (MIT) into spec_cases/bash/bashbox-*.test.sh, keeping only cases whose recorded output matches host bash. 624 pass and join the bash comparison gate; 420 are marked TODO skips: real gaps where bashkit differs from bash. Attribution in NOTICE; process in knowledge/operations/testing.md.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 76f2857 | Commit Preview URL Branch Preview URL |
Oct 07 2026, 06:18 PM |
…-eafupr-bashbox-corpus # Conflicts: # THIRD_PARTY_LICENSES/README.md
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Михайло · project thread
What changed
Adds 65 spec files (
spec_cases/bash/bashbox-*.test.sh, one per BashBox test file) with 1,044 bash-parity cases copied from shipfastlabs/bashbox, a MIT-licensed PHP port of just-bash. BashBox records its expected stdout from GNU bash.### skip: TODO bashbox corpus gap. These are real bugs, where bashkit's stdout or exit status differs from bash. Each follow-up fix PR deletes theskiplines it fixes.Attribution is in
NOTICEandTHIRD_PARTY_LICENSES/README.md. The import rules and how to fix cases are inknowledge/operations/testing.md.Why
This is a large bash-verified corpus that covers areas our own specs miss: declare/local attributes, sort and xargs flags, arithmetic on arrays,
declare -f/typeprinting, named fds, ERR traps, printf and tr escapes.Before / After
Import filter: 1,753 pairs were extracted. 1,095 matched host bash 5.2 (
LANG=C.UTF-8, fresh temp dir). 46 were dropped because the spec format can't represent them (no trailing newline, CR or NUL). 5 were dropped where bashkit matches host bash but the recorded 5.3 output differs.Before:
Total: 2392 | Skipped: 26.After (
cargo test -p bashkit --test integration --features http_client,ssh -- spec_tests::bash_spec_tests spec_tests::bash_comparison_tests --include-ignored):The comparison gate reports no bashbox mismatches locally. Two existing non-bashbox cases (
empty_heredoc,heredoc_empty) mismatch the bash 5.2 in my container and are unrelated to this change.Risk
bash_diffmarker.Checklist