Repository navigation
fix(arithmetic): budget expanded array keys before allocation - #2689
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 83b021d | Commit Preview URL Branch Preview URL |
Oct 11 2026, 10:55 PM |
chaliy
marked this pull request as ready for review
October 11, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Arithmetic associative-array keys and dollar-expanded expressions reserve intermediate capacity before growth, enforce the existing 64 KiB arithmetic cap, and charge shared work with synchronous cancellation/deadline checks. Shared-budget failures reach callers as request resource errors; subsequent executions can reuse the session.
Why
Repeated scalar substitution could allocate an oversized key before the final array writer checked retained memory. The arithmetic recursion guard did not enforce shared live-memory/work budgets during construction (TM-DOS-026).
Before / After
A bounded
Bash::execregression uses a 64-byte scalar, 32 substitutions, and a 512-byte intermediate limit. Before, arithmetic assignment succeeded and stored a 2 KiB key. After, assignments, updates, and reads reject with a typed resource-limit error; a fresh execution printsrecoveredand reports zero entries.Validation:
just pre-pr: green on the latest synchronized branch.5(exit 0); a bounded 96 KiB expanded key reportsexpression too long(expected exit 1).Risk
Checklist