Repository navigation
fix(fmt): budget amplified output before allocation - #2692
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 7c2f9eb | Commit Preview URL Branch Preview URL |
Oct 11 2026, 11:21 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fmtreserves generated output capacity against the shared live-memory budget before allocation. Repeated indentation/prefix bytes and optimal-fit searches also consume work and observe cancellation/deadlines. Budget failures propagate to callers instead of returning successful partial output. Valid formatting, pipes, and VFS redirects retain their existing behavior.Why
A small indented paragraph could multiply into gigabytes in an ordinary output buffer before downstream stdout capture applied. The synchronous formatter also ran without checking its execution deadline.
Before / After
Risk
Medium: intentionally rejects formatter output/search work exceeding configured execution budgets. Existing layout/option behavior stays covered by formatter tests and a finite real-Bash/host-fmt differential. Uses existing budget-owned buffers; no dependencies or permission changes.
Validation
just pre-prjust testcargo clippy --all-targets --all-features -- -D warningscargo deny checkcargo test --test proptest_security -- --test-threads=1cargo bench --bench parallel_executionChecklist