Skip to content

Fix investigation tour availability after organization loads #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejsmith merged 2 commits into from
Sep 28, 2026
Merged

Fix investigation tour availability after organization loads #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03871fc
Keep investigation tour query reactive while organization loads
niemyjski Sep 25, 2026
670c17e
Track tour query gate explicitly and reject placeholder availability
niemyjski Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Exceptionless.Web/ClientApp/src/lib/features/events/api.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ export function getOrganizationCountQuery(request: GetOrganizationCountRequest)

export function getOrganizationEventsQuery(request: GetOrganizationEventsRequest) {
return createQuery<FetchClientResponse<EventSummaryModel<SummaryTemplateKeys>[]>, ProblemDetails>(() => {
const requestEnabled = request.enabled?.() ?? true;
const organizationId = request.route.organizationId;
const params = request.params
? {
Expand All @@ -464,7 +465,7 @@ export function getOrganizationEventsQuery(request: GetOrganizationEventsRequest
: undefined;

return {
enabled: () => !!accessToken.current && !!organizationId && (request.enabled?.() ?? true),
enabled: () => !!accessToken.current && !!organizationId && requestEnabled,
placeholderData: keepPreviousData,
queryFn: async () => {
const client = useFetchClient();
Expand Down
2 changes: 1 addition & 1 deletion ...tionless.Web/ClientApp/src/lib/features/product-tours/components/product-tour-host.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
}
});
const errorEventAvailability = $derived.by((): ProductTourContext['errorEventAvailability'] => {
if (!organizationId || !catalogOpen || errorEventsQuery.isPending) {
if (!organizationId || !catalogOpen || errorEventsQuery.isPending || errorEventsQuery.isPlaceholderData) {
return 'loading';
}

Expand Down
Loading